Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: forbid generate PointGet plan with partition table + _tidb_rowid #54592

Merged
merged 8 commits into from
Jul 19, 2024
Merged

planner: forbid generate PointGet plan with partition table + _tidb_rowid #54592

merged 8 commits into from
Jul 19, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Jul 12, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #54583

Problem Summary: For partitioned tables, it is not possible to determine which partition the row belongs to through _tidb_rowid, so the PointGet plan cannot obtain correct results. We should ban it.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Forbid generate `PointGet` plan with partition table + `_tidb_rowid`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 12, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jul 12, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.4162%. Comparing base (5b5915b) to head (9d11984).
Report is 47 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #54592         +/-   ##
=================================================
- Coverage   72.9011%   56.4162%   -16.4850%     
=================================================
  Files          1549       1673        +124     
  Lines        436313     617023     +180710     
=================================================
+ Hits         318077     348101      +30024     
- Misses        98726     245336     +146610     
- Partials      19510      23586       +4076
Flag Coverage Δ
integration 37.1440% <100.0000%> (?)
unit 71.7614% <25.0000%> (-0.1775%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5468% <ø> (+6.6561%) ⬆️

@Defined2014 Defined2014 requested a review from mjonss July 12, 2024 05:50
@Defined2014 Defined2014 requested a review from qw4990 July 12, 2024 09:49
@pingcap pingcap deleted a comment from ti-chi-bot bot Jul 13, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 13, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2024
@Defined2014
Copy link
Contributor Author

Updated, @mjonss @qw4990 PTAL

@Defined2014 Defined2014 requested review from AilinKid and mjonss July 15, 2024 09:33
mjonss
mjonss approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor suggestions.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 17, 2024
@Defined2014 Defined2014 requested a review from winoros July 17, 2024 12:20
@Defined2014 Defined2014 requested a review from hawkingrei July 18, 2024 07:33
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-17 09:50:47.446722349 +0000 UTC m=+433869.437663820: ☑️ agreed by mjonss.
  • 2024-07-19 03:10:53.997191438 +0000 UTC m=+582675.988132909: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot bot merged commit ddcaadb into pingcap:master Jul 19, 2024
23 checks passed
@Defined2014 Defined2014 added the affects-8.1 This bug affects the 8.1.x(LTS) versions. label Jul 19, 2024
@AilinKid AilinKid added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed affects-8.1 This bug affects the 8.1.x(LTS) versions. labels Jul 19, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 19, 2024
@Defined2014 @ti-chi-bot
planner: forbid generate PointGet plan with partition table + `_tid…
0eb1773 
…b_rowid` (pingcap#54592)

close pingcap#54583
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 19, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #54772.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 19, 2024
@ti-chi-bot
planner: forbid generate PointGet plan with partition table + `_tid…
5299985 
…b_rowid` (#54592) (#54772)

close #54583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@winoros winoros winoros approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@AilinKid AilinKid Awaiting requested review from AilinKid

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

partition table does not return the right rows by quering by _tidb_rowid
5 participants
@Defined2014 @ti-chi-bot @mjonss @winoros @AilinKid